Expose syncscope parameter for atomic add/sub #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LLVM only explicitly documents the system and singlethread synchronization scopes, AFAIU everything else is target-specific. It seems weird to have to hard-code the scopes here then, although I guess that's a result of the design of the API here. (It would be much easier if we'd have the ability to |
maleadt
reviewed
Aug 6, 2024
maleadt
reviewed
Aug 6, 2024
|
SGTM. I take it you've verified that this design works for AMDGPU.jl and is good to go? |
Yes, I have everything else ready to go as well. |
vchuravy
pushed a commit
to JuliaConcurrent/UnsafeAtomics.jl
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying syncscope
"agent"to atomic add/sub enabled fast hardware atomics on AMDGPU targets.The plan is to also have AMDGPU extension for Atomix which will expose
syncscopefor@atomicmacro for+-ops.